fix(cubemaster): rebuild stale rootfs artifacts#857
Draft
ZhiyaoWen999 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #852.
This change prevents CubeMaster from reusing a READY rootfs artifact record when the master-local ext4 file is stale or missing. Before returning a reusable artifact, CubeMaster now verifies that the ext4 file exists, is a regular file, matches the stored size, and matches the stored SHA256. If validation fails, the existing build path claims the artifact row and rebuilds it instead of distributing stale metadata to Cubelet.
Why
After a CubeMaster Pod restart with ephemeral local storage, the database can still contain READY artifact metadata while
/data/CubeMaster/storage/.../*.ext4no longer exists. Reusing that stale metadata causes compute nodes to download invalid content and fail with a SHA256 mismatch. Revalidating the local artifact before reuse makes the create-from-image path self-heal by rebuilding the artifact.Validation
git diff --checkgo test ./pkg/templatecenter -run 'TestValidateReusableRootfsArtifactFile|TestEnsureRootfsArtifactRebuildsMissingReadyArtifact'because the local environment does not have the Go toolchain installed.