docs(adapters): clarify adapter PR boundaries#441
Open
xy200303 wants to merge 1 commit into
Open
Conversation
Signed-off-by: xy200303 <3483421977@qq.com>
fd853cd to
78fd7a3
Compare
YOMXXX
approved these changes
Jul 9, 2026
YOMXXX
left a comment
Contributor
There was a problem hiding this comment.
Approved as a docs-only supplement for the #235 adapter cleanup.
Verified locally:
git diff --check- README/README_CN links point to
docs/adapters/contribution-guide.md docs/adapters/contribution-guide.mdexists
This does not add another adapter implementation; it documents contribution lanes and review boundaries so future #235 adapter PRs can avoid duplicating the shared Gateway client / MCP / coding-agent / Dify scopes.
This was referenced Jul 9, 2026
Collaborator
|
Thanks for your attention! We will review your code and get back to you as soon as possible per our internal schedule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description | 描述
This PR narrows #441 into a documentation-only supplement for the ongoing #235 adapter work.
It adds
docs/adapters/contribution-guide.md, which documents review lanes for parallel adapter PRs:The guide also adds a short review checklist covering session identity, lifecycle hook mapping, Gateway auth, focused tests, and PR body scope notes.
This intentionally does not ship another Gateway SDK implementation, because the reusable Gateway client lane is already covered by #316, while coding-agent and MCP-specific lanes are covered separately by #405 and #372.
Related Issue | 关联 Issue
Related to #235
Complements #316, #405, and #372
Change Type | 修改类型
Self-test Checklist | 自测清单
Additional Notes | 其他说明
Verification performed:
git diff --checkNo runtime code changed.