Skip to content

Conversation

@owilliams320
Copy link
Collaborator

Description

Small style fix for covalent app shell that removes the extra rounded corners for surface items there are a child of the app shell component

What's included?

  • Forces only the top level wrapper card to have the extra rounded corners
  • Child items inherit their default setting

Test Steps

  • npm run storybook
  • then open the app shell story
  • finally to test you need to add a cv-select or cv-menu item in the default slot

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Before
Screenshot 2025-12-02 at 6 55 54 PM
After
Screenshot 2025-12-02 at 6 56 29 PM

@owilliams320 owilliams320 requested a review from omaardev December 3, 2025 00:02
@owilliams320 owilliams320 temporarily deployed to covalent-pip-fix-appshe-anywdy December 3, 2025 00:05 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-fix-appshe-anywdy December 3, 2025 00:12 Inactive
@owilliams320 owilliams320 merged commit 53358c5 into main Dec 3, 2025
7 checks passed
@owilliams320 owilliams320 deleted the fix/appshell-rouded-corners branch December 3, 2025 22:39
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 11.5.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants