-
Notifications
You must be signed in to change notification settings - Fork 62
Force Logback to INFO level #1381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Force Logback to INFO level #1381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but don't we need to set the actual versions in the gradle.properties file?
dd6dd60
to
bed9aa1
Compare
Thanks for the comment, I changed the gradle properties file |
bed9aa1
to
f948874
Compare
tc-server/src/main/java/com/tc/l2/logging/TCLogbackLogging.java
Outdated
Show resolved
Hide resolved
tc-server/src/main/java/com/tc/l2/logging/TCLogbackLogging.java
Outdated
Show resolved
Hide resolved
f948874
to
3c43495
Compare
I updated the approach to keep the INFO level for the console and server logs. Also in
I built a terracotta 12.0 enterprise kit including these terracotta-core changes and tested manually. The console and server are back to what they were with Logback 1.3, and I could pass my custom logback xml. |
|
||
try { | ||
new ch.qos.logback.classic.util.ContextInitializer(loggerContext).autoConfig(); | ||
} catch (Exception e) { | ||
ch.qos.logback.core.util.StatusPrinter.printInCaseOfErrorsOrWarnings(loggerContext); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used for inline testing and is an attempt to shutdown everything for the current server/classloader. The next server/classloader should do this automatically.
Appender<ILoggingEvent> bootstrap = root.getAppender("TC_BASE"); | ||
if (bootstrap != null) { | ||
root.detachAppender(bootstrap); | ||
try { bootstrap.stop(); } catch (Exception ignore) {} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want console output going to the output stream provided to bootstrap logging.
due to default behaviour change in Logback 1.5 where DEBUG is now the new default