Skip to content

Conversation

@na9da
Copy link
Collaborator

@na9da na9da commented May 12, 2025

What this PR does

Fixes #6845

Changes required for terriajs-plugin-proj4leaflet plugin.

TODOs:

  • I have broken up the changes into separate commits. Split into separate PRs if required
  • Fix broken specs
  • Write specs
  • UX review

Test me

TBD

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

na9da added 30 commits May 5, 2025 12:50
Folders in typeRoots should have depth of 1.
…n't changed.

Previously, the camera view would drift when switching between viewer
modes. This is because each time we switch the viewer, we get the current view
from leaflet/cesium scene which renders the map differently. This can be a
problem when restoring share links and the viewer is first initialized in
3d/cesium mode and then switches to leaflet/2d mode.

This change makes sure that the view remains stable if the camera hasn't
changed after setting the initial view.
This is useful for accurately describing extent that crosse the poles where we
need at least 4 lat, lon points.
To allow child classes to override it.
Eg, plugins may provide custom version of Cesium or Leaflet viewers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for 3031 projections - investigation

5 participants