Skip to content

Conversation

@Leo-Fish
Copy link
Contributor

find new flaky tests in spring-authorization-server using Nondex full mode

@Leo-Fish
Copy link
Contributor Author

updated, should be good now.

@@ -1,4 +1,5 @@
Project URL,SHA Detected,Module Path,Fully-Qualified Test Name (packageName.ClassName.methodName),Category,Status,PR Link,Notes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty line should not pass the checker.

@darko-marinov
Copy link
Contributor

@yimingsu01 why does the empty line pass the checker? You or @Leo-Fish should look to fix the checker.

@yimingsu01
Copy link
Contributor

@darko-marinov Please see PR #1874, I've improved the format checker to check for empty lines too.

@darko-marinov
Copy link
Contributor

@Leo-Fish please rebase on the latest main (can do it after Thursday for sure).

@darko-marinov
Copy link
Contributor

Any progress on this?

@Leo-Fish
Copy link
Contributor Author

Leo-Fish commented Dec 2, 2025

Any progress on this?

Sorry, still working on it. The current problem is that the verify_test_type.sh only works for maven projects. Do you want me to write a version that works for gradle?

@darko-marinov
Copy link
Contributor

You can do the checks manually if you want, but it's better if you can use the script. If you add Gradle support, open a PR, and have it accepted, you get bonus "points".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants