-
Notifications
You must be signed in to change notification settings - Fork 297
add new tests in spring-authorization-server #1841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4c0d8bd to
370c6d3
Compare
|
updated, should be good now. |
| @@ -1,4 +1,5 @@ | |||
| Project URL,SHA Detected,Module Path,Fully-Qualified Test Name (packageName.ClassName.methodName),Category,Status,PR Link,Notes | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This empty line should not pass the checker.
|
@yimingsu01 why does the empty line pass the checker? You or @Leo-Fish should look to fix the checker. |
|
@darko-marinov Please see PR #1874, I've improved the format checker to check for empty lines too. |
|
@Leo-Fish please rebase on the latest |
|
Any progress on this? |
Sorry, still working on it. The current problem is that the verify_test_type.sh only works for maven projects. Do you want me to write a version that works for gradle? |
|
You can do the checks manually if you want, but it's better if you can use the script. If you add Gradle support, open a PR, and have it accepted, you get bonus "points". |
find new flaky tests in spring-authorization-server using Nondex full mode