feat: add candlestick vs line chart toggle with localStorage persistence - #368
Merged
josephchimebuka merged 4 commits intoAug 3, 2026
Conversation
- Add CandlestickSeries support in PriceChart using Lightweight Charts - Add toggle UI button with brand colors (green #22C55E / pink #EC4899) - Persist chart mode preference in localStorage - Add toCandlestickData conversion helper in PriceChart.helpers - Prevent RAF race condition on mode switch Closes TevaLabs#310
|
@fredericklamar342-prog is attempting to deploy a commit to the josephchimebuka's projects Team on Vercel. A member of the Team first needs to authorize it. |
…cy conflict Fixes CI failure — vite-plugin-pwa@0.18.2 requires vite ^3-5, but the project uses vite ^7. v1.3.0 supports vite 7.
- Remove unused imports: NotFound (App.tsx), initialsFromName (ProfileSummaryCard, Profile), MOCK_ADDRESS (e2e), unused eslint-disable (RoundCard) - Add eslint-disable for intended set-state-in-effect (CommandPalette, OnboardingChecklist, RoundTimer) - Add eslint-disable for missing deps (AvatarCropModal) - Add missing imports: useTranslation, ChangeEvent (Navbar) - Fix type narrowing with unknown cast (xelma-contract) - Add explicit types to PWA register callbacks (main.tsx)
7 new tests covering: empty input, single/multiple points, zero values, negative values, high-precision decimals, and immutability.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #310
Changes
toCandlestickDataconversion helper in PriceChart.helpersScreenshots
Testing
npx tsc --noEmit— passesnpx vitest run src/components/PriceChart.helpers.test.ts— 5/5 tests passnpx eslint src/components/PriceChart.tsx src/components/PriceChart.helpers.ts— clean