Feat/issue 310 ohlc aggregation - #373
Merged
josephchimebuka merged 16 commits intoAug 3, 2026
Merged
Conversation
- Add CandlestickSeries support in PriceChart using Lightweight Charts - Add toggle UI button with brand colors (green #22C55E / pink #EC4899) - Persist chart mode preference in localStorage - Add toCandlestickData conversion helper in PriceChart.helpers - Prevent RAF race condition on mode switch Closes TevaLabs#310
…cy conflict Fixes CI failure — vite-plugin-pwa@0.18.2 requires vite ^3-5, but the project uses vite ^7. v1.3.0 supports vite 7.
- Remove unused imports: NotFound (App.tsx), initialsFromName (ProfileSummaryCard, Profile), MOCK_ADDRESS (e2e), unused eslint-disable (RoundCard) - Add eslint-disable for intended set-state-in-effect (CommandPalette, OnboardingChecklist, RoundTimer) - Add eslint-disable for missing deps (AvatarCropModal) - Add missing imports: useTranslation, ChangeEvent (Navbar) - Fix type narrowing with unknown cast (xelma-contract) - Add explicit types to PWA register callbacks (main.tsx)
7 new tests covering: empty input, single/multiple points, zero values, negative values, high-precision decimals, and immutability.
|
@fredericklamar342-prog is attempting to deploy a commit to the josephchimebuka's projects Team on Vercel. A member of the Team first needs to authorize it. |
- BetModal/Dashboard tests: add estimatePlaceBet/estimatePrecisionPrediction mocks - PredictionControls test: use value above max (10.0001) instead of below min to avoid jsdom number-input constraint clearing - RoundTimeline test: use getAllByText for Upcoming (now appears in both stage label and current-state badge) - Navbar test: add missing Search icon to lucide-react mock
- PriceChart.tsx: remove duplicate import, dangling first component declaration, and dead LineSeries overwrite block - RoundCard.tsx: use round.closesInSeconds (initialSeconds) for CountdownTimer instead of undefined endTime - RoundTimeline.tsx: remove duplicate prevStateRef declaration
The package-lock.json was corrupted during a merge (missing ']' and '},' between package entries at line 1865), causing npm ci to fail with a JSON parse error. Regenerated the lockfile with 'npm install --package-lock-only' to match the current package.json dependency tree. No dependency versions or package.json were changed.
- Remove duplicate imports in Navbar, xelma-contract, and RoundTimer - Fix syntactically broken useEffect in AvatarCropModal - Remove duplicate state declarations in OnboardingChecklist - Drop unused endTime state in RoundCard - Add missing prevStateRef declaration in RoundTimeline - Fix broken mock objects in BetModal.test and Dashboard.terminal.test - Clean up PWA registration merge conflict in main.tsx - Re-add scValToNative import used by simulateReadOnly Closes the CI 'Lint and Test' failure on PR TevaLabs#373
Fixes ReferenceError: useState is not defined that caused a11y smoke tests and RoundCard unit tests to fail on CI.
- Restore Settings route in App.tsx (accidentally removed with NotFound) - Restore inspectSorobanState import in Dashboard.tsx - Restore WalletId type import in WalletConnect.tsx - Remove unused @ts-expect-error in main.tsx - Merge duplicate mockUserStats imports in Dashboard.tsx
- BetModal: remove duplicate 'Confirm' text from merge conflict - StatsCard.test: update for RankProgressBar component rendering - RoundTimeline.test: use getAllByText for duplicate 'Upcoming' text - Profile.test: add MemoryRouter wrapper for Link components All 58 test files, 669 tests now pass.
Contributor
Author
|
@ebubechi-ihediwa please check the error it is a pre existing error kindly merge |
Contributor
|
@fredericklamar342-prog Pls can you fix Conflicts and send a message in the group saying you've fixed them so I can merge |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #310