Replace import all syntax with explicit import #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yicong-Huang
commented
Jun 14, 2023
| "# \n" + | ||
| "# class ProcessTupleOperator(UDFOperatorV2):\n" + | ||
| "# \n" + |
There was a problem hiding this comment.
Here I am adding a new line to fix the warning of single blank line between imports and class definitions.
|
After a discussion with @aglinxinyuan, an issue is that |
|
discuss this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not recommended to use
import *statements per PEP 8. It was generally a bad idea to expose the namespace with a wildcard. In our case, pyflakes complains aboutfrom pytexera import *and raises a warning in the UI.This PR uses
import pytexera as ptxand the explicitptx.Tuple,ptx.UDFOperatorV2variables which is considered a better practice. This change is backward compatible so existing UDFs will not be affected.