Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Candlestick Chart Visualization Operator #2709

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

xudongwu-0
Copy link
Collaborator

@xudongwu-0 xudongwu-0 commented Jun 30, 2024

This pull request introduces the Candlestick Chart Visualization operator.

The Candlestick Chart is used to visualize financial data. Each candlestick represents one period (e.g., one day) and shows the open, high, low, and close prices. This chart type is commonly used in trading and stock analysis to identify trends and patterns in price movements.

Features:

Displays the date on the x-axis.
Shows open, high, low, and close prices as candlestick bars.
Provides clear visual insights into financial data trends.

Data example:
candlestick_data.csv

screenshot
image

For more information on using the Candlestick Chart functionality within Plotly, please look at the documentation.

@xudongwu-0 xudongwu-0 requested review from Yicong-Huang and aglinxinyuan and removed request for Yicong-Huang June 30, 2024 19:36
@xudongwu-0 xudongwu-0 changed the title Xudong - add Candlestick Chart Visualization Operator add Candlestick Chart Visualization Operator Jul 1, 2024
@aglinxinyuan aglinxinyuan changed the title add Candlestick Chart Visualization Operator Add Candlestick Chart Visualization Operator Jul 1, 2024
@xudongwu-0 xudongwu-0 force-pushed the xudong-add-candlestick-operator branch from fb9058e to d1e7545 Compare July 1, 2024 22:30
@xudongwu-0 xudongwu-0 force-pushed the xudong-add-candlestick-operator branch from d1e7545 to a81063a Compare July 1, 2024 22:50
@aglinxinyuan aglinxinyuan requested review from yunyad and removed request for aglinxinyuan July 2, 2024 21:43
Copy link
Collaborator

@yunyad yunyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Please address the comments. Also, consider replacing the MP4 file with a GIF, as the MP4 took me a few minutes to view, which is inefficient.

@xudongwu-0 xudongwu-0 force-pushed the xudong-add-candlestick-operator branch from 97890a5 to 25889e1 Compare July 5, 2024 22:10
@xudongwu-0 xudongwu-0 force-pushed the xudong-add-candlestick-operator branch from 6ad846f to d55abc3 Compare July 5, 2024 22:36
@xudongwu-0 xudongwu-0 requested a review from yunyad July 5, 2024 22:48
Copy link
Collaborator

@yunyad yunyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xudongwu-0 xudongwu-0 merged commit 1e0220d into master Jul 8, 2024
8 checks passed
@xudongwu-0 xudongwu-0 deleted the xudong-add-candlestick-operator branch July 8, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants