Add Log Plot Support to Scatter Plot Visualization Operator #2712
Conversation
|
Hey @sixsage, I wanted to let you know that your PR looks excellent! My only suggestion is that the plot appears similar to the existing scatter plot. Both use the Plotly API but with different parameters. Instead of creating the log plot as a new visualization operator, it would be nice to integrate your work into the scatter plot. I'm curious to hear your thoughts on this. Thank you. |
|
Thank you for bringing that up. I agree that the log plot can be integrated into the scatter plot operator and I will make the change. Should I close this PR and start a new PR when I am done or should I keep this open? |
sixsage
changed the title
|
Hello @kunwp1 - I have made the changes you have kindly suggested. If you have the time it would be great if you could review my PR once more. Thank you! |
...cala/edu/uci/ics/texera/workflow/operators/visualization/scatterplot/ScatterplotOpDesc.scala
Outdated
Show resolved
Hide resolved
**Purpose**: The purpose of the PR is to solve the issue where the server startup script won't work properly due to the enormous list of dependencies. **Description**: Use java argument file as a workaround to solve the command line argument too long problem. Added a new bash script template to generate the startup script. Fix: #2712 --------- Co-authored-by: Xinyuan Lin <[email protected]>
Purpose
Modify the scatter plot operator to support log-scaling in the X and/or Y axis
Description of Changes
As suggested by kunwp1, log plot was originally a visualization operator on its own but decided to merge it to scatter plot operator instead.
The log-scaling arguments were found here