Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icicle Chart Visualization Operator #2716

Merged
merged 13 commits into from
Jul 7, 2024

Conversation

savahebert
Copy link
Collaborator

@savahebert savahebert commented Jul 2, 2024

Purpose

Add Icicle Chart to visualize hierarchical data as rectangles organized from root (the higher-level attribute) to leaves (the lower-level attributes).

Description of Changes

Implemented the Python Plotly.express icicle chart as a Java native operator and embedded the output as HTML.

Demonstration

image

@aglinxinyuan aglinxinyuan changed the title Icicle Chart Visualization Operator Add Icicle Chart Visualization Operator Jul 2, 2024
@aglinxinyuan aglinxinyuan self-requested a review July 2, 2024 21:44
@savahebert savahebert marked this pull request as ready for review July 2, 2024 22:15
@aglinxinyuan aglinxinyuan requested review from bobbai00 and removed request for aglinxinyuan July 4, 2024 02:43
Copy link
Collaborator

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some reviews. Generally look good! Remember to pick a icon image

@bobbai00
Copy link
Collaborator

bobbai00 commented Jul 5, 2024

Another comment is: add more description in your PR description. Please refer to previous merged PRs' description as the example. Thanks

@savahebert
Copy link
Collaborator Author

Thanks for the feedback. I have completed the requested changes. Let me know if there's anything else I can do.

Copy link
Collaborator

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please resolve the conflicts with the latest master.

@savahebert savahebert merged commit 7bd3141 into master Jul 7, 2024
8 checks passed
@savahebert savahebert deleted the savannah-visualization-operator branch July 7, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants