-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Icicle Chart Visualization Operator #2716
Conversation
...cala/edu/uci/ics/texera/workflow/operators/visualization/IcicleChart/IcicleChartOpDesc.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some reviews. Generally look good! Remember to pick a icon image
...cala/edu/uci/ics/texera/workflow/operators/visualization/IcicleChart/IcicleChartOpDesc.scala
Outdated
Show resolved
Hide resolved
...cala/edu/uci/ics/texera/workflow/operators/visualization/IcicleChart/IcicleChartOpDesc.scala
Outdated
Show resolved
Hide resolved
Another comment is: add more description in your PR description. Please refer to previous merged PRs' description as the example. Thanks |
…Texera/texera into savannah-visualization-operator
…Texera/texera into savannah-visualization-operator
Thanks for the feedback. I have completed the requested changes. Let me know if there's anything else I can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please resolve the conflicts with the latest master.
Purpose
Add Icicle Chart to visualize hierarchical data as rectangles organized from root (the higher-level attribute) to leaves (the lower-level attributes).
Description of Changes
Implemented the Python Plotly.express icicle chart as a Java native operator and embedded the output as HTML.
Demonstration