Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update build target from ES5 to ES6 #317

Merged
merged 2 commits into from
Apr 25, 2023
Merged

build: update build target from ES5 to ES6 #317

merged 2 commits into from
Apr 25, 2023

Conversation

pionxzh
Copy link
Collaborator

@pionxzh pionxzh commented Apr 25, 2023

No description provided.

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit b1ec243
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/6447bd534716fb00089d6d5c
😎 Deploy Preview https://deploy-preview-317--any-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pionxzh pionxzh changed the base branch from main to v3.x April 25, 2023 11:45
@rtritto
Copy link
Contributor

rtritto commented Apr 25, 2023

@pionxzh next step is to use ESNext?

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v3.x@e57d620). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x     #317   +/-   ##
=======================================
  Coverage        ?   88.48%           
=======================================
  Files           ?       25           
  Lines           ?     2345           
  Branches        ?      414           
=======================================
  Hits            ?     2075           
  Misses          ?      269           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pionxzh
Copy link
Collaborator Author

pionxzh commented Apr 25, 2023

@rtritto wait, what's your definition of ESNext? This is V3 branch. I want to drop the support for IE, so I update the target to ES6.

@pionxzh pionxzh marked this pull request as draft April 25, 2023 11:58
@rtritto
Copy link
Contributor

rtritto commented Apr 25, 2023

The special ESNext value refers to the highest version your version of TypeScript supports. This setting should be used with caution, since it doesn’t mean the same thing between different TypeScript versions and can make upgrades less predictable.

Source: https://www.typescriptlang.org/tsconfig#target

@pionxzh
Copy link
Collaborator Author

pionxzh commented Apr 25, 2023

I think ESNext is risky...
I just checked, as the fact that we are using MUI, we should be able to directly follow their browserslistrc range?

@pionxzh
Copy link
Collaborator Author

pionxzh commented Apr 25, 2023

Nice. 80 KB -> 63 KB 😄

@pionxzh pionxzh marked this pull request as ready for review April 25, 2023 13:39
@pionxzh pionxzh merged commit 6542c5b into v3.x Apr 25, 2023
@pionxzh pionxzh deleted the build-target branch April 25, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants