Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should handle key and path of nested grouped array with nestedIndex #420

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

pionxzh
Copy link
Collaborator

@pionxzh pionxzh commented Nov 4, 2023

closes #419

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit adcf08b
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/65465e5d52d0210008302f03
😎 Deploy Preview https://deploy-preview-420--any-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a757e8) 87.93% compared to head (adcf08b) 87.95%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   87.93%   87.95%   +0.02%     
==========================================
  Files          25       25              
  Lines        2387     2391       +4     
  Branches      379      382       +3     
==========================================
+ Hits         2099     2103       +4     
  Misses        287      287              
  Partials        1        1              
Files Coverage Δ
src/components/DataKeyPair.tsx 65.01% <100.00%> (+0.10%) ⬆️
src/components/DataTypes/Object.tsx 87.94% <100.00%> (+0.07%) ⬆️
src/type.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pionxzh pionxzh merged commit 6efeac6 into TexteaInc:main Nov 4, 2023
12 checks passed
@pionxzh pionxzh deleted the nested branch November 4, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Indexing issue leads to PATH error
1 participant