Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support add and delete feature #438

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

pionxzh
Copy link
Collaborator

@pionxzh pionxzh commented Jan 15, 2024

closes #437

This PR adds the functionality to add and delete values. These features are not designed to work out of the box. You will have to implement the behavior manually. The library will expose the necessary helpers for you to achieve that, and this kind of low-level API can also be used for advanced use cases.

image

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit 5474c87
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/65a5e8feb609b000081e5caa
😎 Deploy Preview https://deploy-preview-438--any-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/utils/index.ts Fixed Show fixed Hide fixed
src/utils/index.ts Fixed Show fixed Hide fixed
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (6efeac6) 87.95% compared to head (5474c87) 86.81%.
Report is 9 commits behind head on main.

Files Patch % Lines
src/components/DataKeyPair.tsx 33.33% 48 Missing ⚠️
src/components/Icons.tsx 60.00% 4 Missing ⚠️
src/stores/JsonViewerStore.ts 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   87.95%   86.81%   -1.15%     
==========================================
  Files          25       25              
  Lines        2391     2563     +172     
  Branches      382      405      +23     
==========================================
+ Hits         2103     2225     +122     
- Misses        287      337      +50     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pionxzh pionxzh merged commit 1709001 into TexteaInc:main Jan 16, 2024
11 of 13 checks passed
@pionxzh pionxzh deleted the add-delete branch January 16, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add/Delete functionality
1 participant