Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing/incorrect key when rendering self referential objects #450

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

shaswat-indian
Copy link
Contributor

This PR fixes the issue when the key was either missing (when rootName=false) or the key was rendered as "root" if it wasn't set.

For example, for the given object:-

const value: any = {
  text: 'Hello World'
}
value.self = value;

Before (with rootName=false)
Screenshot 2024-02-07 at 6 29 03 PM

After (with rootName=false)
Screenshot 2024-02-07 at 6 28 36 PM

Before (with default rootName)
Screenshot 2024-02-07 at 6 29 27 PM

After (with default rootName)
Screenshot 2024-02-07 at 6 29 52 PM

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for any-viewer ready!

Name Link
🔨 Latest commit 9544bd2
🔍 Latest deploy log https://app.netlify.com/sites/any-viewer/deploys/65c4401f2430220009166798
😎 Deploy Preview https://deploy-preview-450--any-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shaswat-indian
Copy link
Contributor Author

@pionxzh Could I get a review on this, please?

@pionxzh pionxzh merged commit 95ee8ca into TexteaInc:main Feb 9, 2024
10 checks passed
@pionxzh
Copy link
Collaborator

pionxzh commented Feb 9, 2024

LGTM. Thanks 🙏

@pionxzh
Copy link
Collaborator

pionxzh commented Feb 9, 2024

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants