Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted displaying Decision Comment when adding a risk #245

Merged

Conversation

ThomasDThales
Copy link
Contributor

@ThomasDThales ThomasDThales commented Apr 19, 2024

A function was executed at the wrong time so implied an error and was in fact useless

…s executed at the wrong time so i;plied an error and was in fact useless + added condition to addSelectedRowData to fixing issues when deleting risks (could not find the risk related to a given id)
@Alvin-JohnPagente
Copy link
Contributor

To reproduce the issue:

  • Launch sratool
  • Go to Risks tab. The tab will have one risk by default. Scroll to the Risk Mitigation...
    image
  • Now add a new Risk. The active risk is Bump tinymce from 6.2.0 to 6.3.1 in /app #1.
    image
  • Scroll to the Risk Mitigation, notice that the mitigation decision is shown even when the decision = Not defined
    image

@Alvin-JohnPagente
Copy link
Contributor

@ThomasDThales This pull requests fixes 2 issues. Can you update the pull request title to describe the pull request more accurately

@ThomasDThales ThomasDThales changed the title deleted displaying Decision Comment when adding a risk deleted displaying Decision Comment when adding a risk + added verifications to avoid referring to undefined risk id May 20, 2024
@ThomasDThales
Copy link
Contributor Author

@ThomasDThales This pull requests fixes 2 issues. Can you update the pull request title to describe the pull request more accurately

Done

@ThomasDThales ThomasDThales changed the title deleted displaying Decision Comment when adding a risk + added verifications to avoid referring to undefined risk id deleted displaying Decision Comment when adding a risk May 20, 2024
Copy link
Contributor

@Alvin-JohnPagente Alvin-JohnPagente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that issue is fixed

@Alvin-JohnPagente Alvin-JohnPagente merged commit 264ead8 into master May 20, 2024
2 checks passed
@Alvin-JohnPagente Alvin-JohnPagente deleted the hotfix/adding-risk-displays-mitigation-panels- branch May 20, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants