Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split conditions #283

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Split conditions #283

merged 1 commit into from
Jun 5, 2024

Conversation

ThomasDThales
Copy link
Contributor

The conditions that were to difficult to read have been split in multiple lines

Example :
image

To

image

@ThomasDThales
Splited conditions
57d301d 
The conditions that were to difficult to read have been split in multiple lines
Alvin-JohnPagente
Alvin-JohnPagente approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@Alvin-JohnPagente Alvin-JohnPagente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good. However this is not the only part of the code with formatting issues. We should run a linter or code formatter check to discover other issues and maybe automatically fix it.

@Alvin-JohnPagente Alvin-JohnPagente merged commit d8d2a1d into master Jun 5, 2024
2 checks passed
@Alvin-JohnPagente Alvin-JohnPagente deleted the hotfix/multiple-lines-conditions-checking-functions branch June 5, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alvin-JohnPagente Alvin-JohnPagente Alvin-JohnPagente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasDThales @Alvin-JohnPagente