Deprecated Item Restoration Part 2 #1465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like something went very wrong in the process of uploading this pull request. If need be, I'll send the source code of the commit. |
GrenderG
reviewed
Dec 4, 2024
| end if; | ||
|
|
||
| -- 22/11/2024 1 | ||
| if (select count(*) from applied_updates where id='111120241') = 0 then |
There was a problem hiding this comment.
Seems like you are using the wrong id here (should be 221120241) and also forgot to add insert into applied_updates values ('221120241'); at the end of the update block.
|
That seems to have fixed it, thanks. For some clarification, I think that id was correct since that matches the date I originally started working on the commit, but I changed it to today to be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds even more deprecated and unused items back into the game, as well as restores some items back to their original names/versions. Also fixes some displayIDs for pre-existing items like Scarlet Insignia Rings.