Player Statistics UI #756
Merged
Player Statistics UI #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… because it never did that
Not linked up to main player UI yet either
…n, fix stats toggle button text
b5635
reviewed
Jul 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on discord, this has the slight issue that some characters have BIC db data already, which won't be added to their "account total".
The clean solution is probably to have one db and have a entry for each stat for each character, and use sqlite to sum it all up dynamically.
This change doesn't really make that any harder to do later, because the steps to get there are still the same (destroy the current account total settings, move the player BIC records to the new database table and destroy the one in the BIC).
... but I had already written this one!