Refactor AutoTuner as Python module #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luarss
reviewed
Oct 28, 2024
eszpotanski
force-pushed
the
eszpot/autotuner-refactoring
branch
2 times, most recently
from
256ce2d to
fe29652
Compare
luarss
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Approval is pending smoke test re-enablement @vvbandeira fyi.
@eszpotanski No action needed for now, for this PR
|
FWIW, I've run the PR through some local quick testing and it appears to work for the non-cluster tune and sweep mode tests that I ran (not exhaustive, of course). I've also started to apply my own re-factoring on top of this PR, so that I can send those up for review after this PR gets merged. |
vvbandeira
approved these changes
Jan 28, 2025
|
@eszpotanski |
Signed-off-by: Eryk Szpotanski <[email protected]>
Signed-off-by: Eryk Szpotanski <[email protected]>
Signed-off-by: Eryk Szpotanski <[email protected]>
Signed-off-by: Eryk Szpotanski <[email protected]>
auto-merge was automatically disabled
January 29, 2025 10:55
Head branch was pushed to by a user without write access
eszpotanski
force-pushed
the
eszpot/autotuner-refactoring
branch
from
fe29652 to
dc6be33
Compare
vvbandeira
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the structure of AutoTuner, so it can be used as a Python module. It also move part of the code (not closely related to tuning) to separate
utilsfile.