Skip to content

[DO NOT REVIEW] Mock array with input output registers #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

oharboe
Copy link
Collaborator

@oharboe oharboe commented Nov 25, 2024

No description provided.

This makes the design more interesting w.r.t. timing repair

Signed-off-by: Øyvind Harboe <[email protected]>
@oharboe
Copy link
Collaborator Author

oharboe commented Nov 26, 2024

CTS created a surprising amount of skew here:

image

@maliberty
Copy link
Member

That's pretty ugly - where were the registers placed? @arthurjolo is working a similar looking issue in another design.

@oharboe
Copy link
Collaborator Author

oharboe commented Nov 26, 2024

That's pretty ugly - where were the registers placed? @arthurjolo is working a similar looking issue in another design.

Perhaps this is a downstream effect of the macro placement problem?

There are flip flops on all inputs/outputs around of what should be an 8x8 array centered element array:

image

@maliberty
Copy link
Member

I would wait for the macro to be resolved and see

@oharboe
Copy link
Collaborator Author

oharboe commented Nov 26, 2024

I would wait for the macro to be resolved and see

Yes. No rush: there are several layers to this onion PR before it can be merged...

@oharboe
Copy link
Collaborator Author

oharboe commented Nov 26, 2024

The mock-array has accumulated an impressive number of layers of use-cases by now... That's both good and bad. Ideally there would be single concern unit-tests for each use-case.

@oharboe
Copy link
Collaborator Author

oharboe commented Nov 27, 2024

@oharboe
Copy link
Collaborator Author

oharboe commented Nov 28, 2024

@maliberty @eder-matheus The IO placement is funny with this change(once macro placement is fixed) :-)

The pins should be just across from the rows/columns, but the pins are bundled into the upper right and lower left corner.

This of course messes up placement and routing. The CTS looks more reasonable with a good macro placmenet though.

image

@eder-matheus
Copy link
Contributor

@oharboe Could you send a tar file with the artifacts for this run?

@oharboe
Copy link
Collaborator Author

oharboe commented Nov 28, 2024

@oharboe Could you send a tar file with the artifacts for this run?

Never mind :-) Mea culpa, I swapped x/y in manual placement

@oharboe
Copy link
Collaborator Author

oharboe commented Nov 29, 2024

To make it build, rebase on master, disable automatic macro placement and disable hold repair(false violations in floorplan will stop the build).

Will fail in drt

make DESIGN_CONFIG=designs/asap7/mock-array/config.mk RTLMP_FLOW=0 HOLD_SLACK_MARGIN=-200

image

image

@oharboe oharboe reopened this Dec 18, 2024
@oharboe oharboe closed this Dec 18, 2024
@oharboe oharboe deleted the mock-array-with-input-output-registers branch February 3, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants