-
Notifications
You must be signed in to change notification settings - Fork 337
[DO NOT REVIEW] Mock array with input output registers #2589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT REVIEW] Mock array with input output registers #2589
Conversation
This makes the design more interesting w.r.t. timing repair Signed-off-by: Øyvind Harboe <[email protected]>
Signed-off-by: Øyvind Harboe <[email protected]>
That's pretty ugly - where were the registers placed? @arthurjolo is working a similar looking issue in another design. |
Perhaps this is a downstream effect of the macro placement problem? There are flip flops on all inputs/outputs around of what should be an 8x8 array centered element array: |
I would wait for the macro to be resolved and see |
Yes. No rush: there are several layers to this onion PR before it can be merged... |
The mock-array has accumulated an impressive number of layers of use-cases by now... That's both good and bad. Ideally there would be single concern unit-tests for each use-case. |
@maliberty This PR is extending testcases, close it so it is out of sight out and out of mind until fixes in OpenROAD land: |
@maliberty @eder-matheus The IO placement is funny with this change(once macro placement is fixed) :-) The pins should be just across from the rows/columns, but the pins are bundled into the upper right and lower left corner. This of course messes up placement and routing. The CTS looks more reasonable with a good macro placmenet though. |
@oharboe Could you send a tar file with the artifacts for this run? |
Never mind :-) Mea culpa, I swapped x/y in manual placement |
To make it build, rebase on master, disable automatic macro placement and disable hold repair(false violations in floorplan will stop the build). Will fail in drt
|
No description provided.