Merge pull request #6513 from The-OpenROAD-Project-staging/odb-rm-dbI…

…dValidation odb: rm obsolete dbIdValidation
The-OpenROAD-Project · Jan 13, 2025 · 0f1f508 · 0f1f508
2 parents 29fbad4 + 0ca23c5
commit 0f1f508
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 27 deletions.
diff --git a/src/odb/include/odb/dbId.h b/src/odb/include/odb/dbId.h
@@ -36,13 +36,6 @@
 
 namespace odb {
 
-class dbIdValidation
-{
- public:
-  static uint invalidId() { return 0; }
-  static bool isId(const char* inid);
-};
-
 //
 // April 2006 twg -
 //

diff --git a/src/odb/src/db/dbTechLayerAntennaRule.cpp b/src/odb/src/db/dbTechLayerAntennaRule.cpp
@@ -916,7 +916,7 @@ void _dbTechAntennaAreaElement::writeLef(const char* header,
                                          lefout& writer) const
 {
   fmt::print(writer.out(), "        {} {:g} ", header, _area);
-  if (_lyidx != dbIdValidation::invalidId()) {
+  if (_lyidx.isValid()) {
     fmt::print(writer.out(),
                "LAYER {} ",
                dbTechLayer::getTechLayer(tech, _lyidx)->getName().c_str());

diff --git a/src/odb/src/db/dbTechLayerAntennaRule.h b/src/odb/src/db/dbTechLayerAntennaRule.h
@@ -200,7 +200,7 @@ class _dbTechAntennaAreaElement
  private:
   _dbTechAntennaAreaElement() = default;
   double _area{-1.0};
-  dbId<_dbTechLayer> _lyidx{dbIdValidation::invalidId()};
+  dbId<_dbTechLayer> _lyidx;
 };
 
 //

diff --git a/src/odb/src/db/dbTypes.cpp b/src/odb/src/db/dbTypes.cpp
@@ -39,24 +39,6 @@
 
 namespace odb {
 
-//
-// dbIdValidation methods here
-//
-bool dbIdValidation::isId(const char* inid)
-{
-  if (!inid) {
-    return false;
-  }
-
-  for (; *inid; inid++) {
-    if (isdigit(*inid) == 0) {
-      return false;
-    }
-  }
-
-  return true;
-}
-
 std::optional<dbOrientType::Value> dbOrientType::fromString(const char* orient)
 {
   std::optional<dbOrientType::Value> ret;