odb: removing unnecessary locks

Signed-off-by: Lucas Yuki Imamura <[email protected]>

src/odb/include/odb/lefin.h

@@ -199,7 +199,7 @@ class lefinReader
   lefinReader(dbDatabase* db,
               utl::Logger* logger,
               bool ignore_non_routing_layers);
-  ~lefinReader();
+  ~lefinReader() = default;
 
   // Skip macro-obstructions in the lef file.
   void skipObstructions() { _skip_obstructions = true; }

src/odb/src/defin/defin.cpp

@@ -43,73 +43,61 @@ std::mutex defin::_def_mutex;
 
 defin::defin(dbDatabase* db, utl::Logger* logger, MODE mode)
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader = new definReader(db, logger, mode);
 }
 
 defin::~defin()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   delete _reader;
 }
 
 void defin::skipConnections()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->skipConnections();
 }
 
 void defin::skipWires()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->skipWires();
 }
 
 void defin::skipSpecialWires()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->skipSpecialWires();
 }
 
 void defin::skipShields()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->skipShields();
 }
 
 void defin::skipBlockWires()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->skipBlockWires();
 }
 
 void defin::skipFillWires()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->skipFillWires();
 }
 
 void defin::continueOnErrors()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->continueOnErrors();
 }
 
 void defin::namesAreDBIDs()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->namesAreDBIDs();
 }
 
 void defin::setAssemblyMode()
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->setAssemblyMode();
 }
 
 void defin::useBlockName(const char* name)
 {
-  std::lock_guard<std::mutex> lock(_def_mutex);
   _reader->useBlockName(name);
 }
 

src/odb/src/lefin/lefTechLayerCutSpacingTableParser.cpp

@@ -44,9 +44,10 @@ void createOrthongonalSubRule(
   odb::dbTechLayerCutSpacingTableOrthRule* rule
       = odb::dbTechLayerCutSpacingTableOrthRule::create(parser->layer);
   std::vector<std::pair<int, int>> table;
+  table.reserve(params.size());
   for (const auto& item : params)
-    table.push_back({lefinReader->dbdist(at_c<0>(item)),
-                     lefinReader->dbdist(at_c<1>(item))});
+    table.emplace_back(lefinReader->dbdist(at_c<0>(item)),
+                       lefinReader->dbdist(at_c<1>(item)));
   rule->setSpacingTable(table);
 }
 void createDefSubRule(odb::lefTechLayerCutSpacingTableParser* parser)

src/odb/src/lefin/lefin.cpp

@@ -111,10 +111,6 @@ void lefinReader::init()
   }
 }
 
-lefinReader::~lefinReader()
-{
-}
-
 dbSite* lefinReader::findSite(const char* name)
 {
   dbSite* site = _lib->findSite(name);
@@ -2437,13 +2433,11 @@ lefin::lefin(dbDatabase* db,
              utl::Logger* logger,
              bool ignore_non_routing_layers)
 {
-  std::lock_guard<std::mutex> lock(_lef_mutex);
   _reader = new lefinReader(db, logger, ignore_non_routing_layers);
 }
 
 lefin::~lefin()
 {
-  std::lock_guard<std::mutex> lock(_lef_mutex);
   delete _reader;
 }