Ignore the build directory in clang-tidy

Signed-off-by: Matt Liberty <[email protected]>
The-OpenROAD-Project · Jan 11, 2025 · fbc047a · fbc047a
1 parent d3feb61
commit fbc047a
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 19 deletions.
diff --git a/.gitignore b/.gitignore
@@ -41,6 +41,8 @@ coverage-output
 .metals/
 
 etc/openroad_deps_prefixes.txt
+etc/run-clang-tidy-cached
+OpenROAD_clang-tidy.*
 
 *debhelper*
 debian/changelog

diff --git a/etc/run-clang-tidy-cached.cc b/etc/run-clang-tidy-cached.cc
@@ -125,7 +125,8 @@ static constexpr ConfigValues kConfig = {
     .start_dir = "src/",
     .file_exclude_re
     = "src/sta/"  // Don't check 3rd-party submodule
-      "|codeGenerator/templates/",
+      "|codeGenerator/templates/"
+      "|build/",  // Don't check generated code
     .revisit_brokenfiles_if_build_config_newer = false,
 };
 // --------------------------------------------------------------

diff --git a/src/drt/src/TritonRoute.cpp b/src/drt/src/TritonRoute.cpp
@@ -220,9 +220,10 @@ std::string TritonRoute::runDRWorker(const std::string& workerStr,
 {
   bool on = debug_->debugDR;
   std::unique_ptr<FlexDRGraphics> graphics_
-      = on && FlexDRGraphics::guiActive() ? std::make_unique<FlexDRGraphics>(
-            debug_.get(), design_.get(), db_, logger_)
-                                          : nullptr;
+      = on && FlexDRGraphics::guiActive()
+            ? std::make_unique<FlexDRGraphics>(
+                  debug_.get(), design_.get(), db_, logger_)
+            : nullptr;
   auto worker = FlexDRWorker::load(
       workerStr, viaData, design_.get(), logger_, router_cfg_.get());
   worker->setGraphics(graphics_.get());
@@ -250,9 +251,10 @@ void TritonRoute::debugSingleWorker(const std::string& dumpDir,
   ar >> viaData;
 
   std::unique_ptr<FlexDRGraphics> graphics
-      = on && FlexDRGraphics::guiActive() ? std::make_unique<FlexDRGraphics>(
-            debug_.get(), design_.get(), db_, logger_)
-                                          : nullptr;
+      = on && FlexDRGraphics::guiActive()
+            ? std::make_unique<FlexDRGraphics>(
+                  debug_.get(), design_.get(), db_, logger_)
+            : nullptr;
   std::ifstream workerFile(fmt::format("{}/worker.bin", dumpDir),
                            std::ios::binary);
   std::string workerStr((std::istreambuf_iterator<char>(workerFile)),

diff --git a/src/drt/src/gc/FlexGC.cpp b/src/drt/src/gc/FlexGC.cpp
@@ -37,7 +37,7 @@ FlexGCWorker::FlexGCWorker(frTechObject* techIn,
                            RouterConfiguration* router_cfg,
                            FlexDRWorker* drWorkerIn)
     : impl_(
-        std::make_unique<Impl>(techIn, logger, router_cfg, drWorkerIn, this))
+          std::make_unique<Impl>(techIn, logger, router_cfg, drWorkerIn, this))
 {
 }
 

diff --git a/src/drt/src/io/GuideProcessor.h b/src/drt/src/io/GuideProcessor.h
@@ -50,10 +50,9 @@ class GuideProcessor
                  odb::dbDatabase* dbIn,
                  utl::Logger* loggerIn,
                  RouterConfiguration* router_cfg)
-      : design_(designIn),
-        logger_(loggerIn),
-        db_(dbIn),
-        router_cfg_(router_cfg){};
+      : design_(designIn), logger_(loggerIn), db_(dbIn), router_cfg_(router_cfg)
+  {
+  }
   /**
    * @brief Reads guides from odb and fill the tmp_guides_ list of unprocessed
    * guides
@@ -441,4 +440,4 @@ class GuidePathFinder
   frBlockObjectMap<std::set<Point3D>> pin_gcell_map_;
   std::vector<frRect> rects_;
 };
-}  // namespace drt::io
+}  // namespace drt::io
diff --git a/src/drt/src/pa/FlexPA.cpp b/src/drt/src/pa/FlexPA.cpp
@@ -72,7 +72,7 @@ void FlexPA::setDebug(frDebugSettings* settings, odb::dbDatabase* db)
   const bool on = settings->debugPA;
   graphics_ = on && FlexPAGraphics::guiActive()
                   ? std::make_unique<FlexPAGraphics>(
-                      settings, design_, db, logger_, router_cfg_)
+                        settings, design_, db, logger_, router_cfg_)
                   : nullptr;
 }
 

diff --git a/src/drt/src/ta/FlexTA.h b/src/drt/src/ta/FlexTA.h
@@ -135,7 +135,9 @@ class FlexTAWorker
         numAssigned_(0),
         totCost_(0),
         maxRetry_(1),
-        hardIroutesMode(false){};
+        hardIroutesMode(false)
+  {
+  }
   // setters
   void setRouteBox(const Rect& boxIn) { routeBox_ = boxIn; }
   void setExtBox(const Rect& boxIn) { extBox_ = boxIn; }

diff --git a/src/rsz/src/RepairDesign.cc b/src/rsz/src/RepairDesign.cc
@@ -486,7 +486,7 @@ bool RepairDesign::performGainBuffering(Net* net,
     const Network* network_;
 
    public:
-    PinRequiredHigher(const Network* network) : network_(network){};
+    PinRequiredHigher(const Network* network) : network_(network) {}
 
     bool operator()(const EnqueuedPin& a, const EnqueuedPin& b) const
     {

diff --git a/src/rsz/src/Resizer.cc b/src/rsz/src/Resizer.cc
@@ -1326,9 +1326,10 @@ LibertyCell* Resizer::findTargetCell(LibertyCell* cell,
     for (LibertyCell* target_cell : swappable_cells) {
       if (!dontUse(target_cell) && isLinkCell(target_cell)) {
         float target_load = (*target_load_map_)[target_cell];
-        float delay = is_buf_inv ? bufferDelay(
-                          target_cell, load_cap, tgt_slew_dcalc_ap_)
-                                 : 0.0;
+        float delay
+            = is_buf_inv
+                  ? bufferDelay(target_cell, load_cap, tgt_slew_dcalc_ap_)
+                  : 0.0;
         float dist = targetLoadDist(load_cap, target_load);
         debugPrint(logger_,
                    RSZ,