drt: elimination of getNoRotationTransform and drt::dbTransform #6326
+65
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnmfw
force-pushed
the
drt_frInstTranform_elimination
branch
from
07e8dc0 to
cf85131
Compare
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
bnmfw
force-pushed
the
drt_frInstTranform_elimination
branch
from
cf85131 to
30011d6
Compare
bnmfw
changed the title
Signed-off-by: bernardo <[email protected]>
bnmfw
force-pushed
the
drt_frInstTranform_elimination
branch
from
30011d6 to
dd9966d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
osamahammad21
requested changes
Dec 9, 2024
Signed-off-by: bernardo <[email protected]>
bnmfw
force-pushed
the
drt_frInstTranform_elimination
branch
from
ce82952 to
e6e7761
Compare
…AD_Bernardo_Sandoval into drt_frInstTranform_elimination
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has an ISPD and Secure CI associated and will be opened when they pass.
Fixes #5712.
Elimination of getNoRotationTransform
Previously on #6141 most use cases of
getUpdatedXformwere refactored to use theodb::dbTransformobject. This allowed for the refactoring ofgetUpdatedXformintogetNoRotationTransformwhich was the use case remaining. The refactored function was only using when recalculation the access points coordinates.During
revertAccessPointschip coordinates are transformed to take the origin of their instance as the 0,0. However, the function was taking the incorrectfrInst::dbTransformas a basis and not taking rotation into consideration. This mistake was compensated bygetNoRotationTransform. NowrevertAccessPointstakes the DB transformation as a basis, which allows the substitution ofgetNoRotationTransformtogetDBTransformwhich is correct and inline with the db.The remaining use of
frInst::dbTranformwas atfrInstTerm::getAccessPointwhere an inverse transformation was done manually. The adequate transformation was used instead.After this modification
frInst::dbTransformwas never accessed, so it was eliminated from the class. This allowed the renaming offrInst::getDBTransformtofrInst::getTransformsince it now is the only transformfrInsthas access to.frInst::setOrientandfrInst::setOriginwere deleted since at no part of the code the DRT actually has to change theodb::dbTransformanymore. This deletion required deleting the methods from the abstract base classfrRef, which in part required the same methods onfrViato not be overrides anymore.Finally at some parts of the code were previously both
getUpdatedXformandgetTransformwere called, only the latter is necessary since their uses are the same, thus only one transformation is used and substitutes the deleted. Some variable name changes were done (MainlyshiftXform->transform). The way the global router orients access points was also changed to conform with these changes.