drt: last name changes and doxygen #6359
Open
+323
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bernardo <[email protected]>
bnmfw
added
drt
|
clang-tidy review says "All clean, LGTM! 👍" |
rovinski
reviewed
Dec 16, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
Co-authored-by: Austin Rovinski <[email protected]> Signed-off-by: Bernardo Borges Sandoval <[email protected]>
bnmfw
force-pushed
the
drt_pa_closing
branch
from
1f45567 to
f630b25
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
osamahammad21
requested changes
Dec 22, 2024
Signed-off-by: bernardo <[email protected]>
Signed-off-by: bernardo <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5721. Finally.
This PR is only aesthetic, it only adds missing Doxygen documentations to most functions on the PA module and changes some names. Some functions, specially on the row_patters and acc_patterns files were left simple as the high level view of both files is pretty straight forward, acc_point is the elaborate one.
Ignoring function name changes to camelCase here are all function name changes, I find they describe the function better (filter describes what is happening way better than check or add). Here are they:
initAllAccessPoints→genAllAccessPointsgen_createAccessPoint→createSingleAccessPointgen_initializeAccessPoints→createMultipleAccessPointscheck_addPlanarAccess→filterPlanarAccesscheck_addViaAccess→filterViaAccesscheckViaAccess→checkViaPlanarAccesscheck_addAccess→filterSingleAPAccessescheck_setAPsAccesses→filterMultipleAPAccessesinitPinAccessCostBounded→genPinAccessCostBoundedinitPinAccess→genPinAccessinitInstAccessPoints→genInstAccessPointsinitAllAccessPoints→genAllAccessPoints