Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hier connect with test #6413

Merged

Conversation

andyfox-rushc
Copy link
Contributor

@andyfox-rushc andyfox-rushc commented Dec 22, 2024

This pull request includes a C++ test case which builds a multiple level hierarchical design and exercises the creation of a hierarchical connection. This involved adding a cpp directory to the dbSta/test area. The main contribution of this pull request is a c++ level creation of a hierarchical test case.
Also included is a bug fix to the construction of the hierarchy extraction (getParentHierarchy) code which was causing a seg fault.
Ready for review.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/dbSta/test/cpp/TestHconn.cpp Outdated Show resolved Hide resolved
src/dbSta/test/cpp/TestHconn.cpp Outdated Show resolved Hide resolved
src/dbSta/test/cpp/TestHconn.cpp Outdated Show resolved Hide resolved
@andyfox-rushc andyfox-rushc marked this pull request as draft December 22, 2024 20:37
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@andyfox-rushc andyfox-rushc marked this pull request as ready for review December 24, 2024 01:11
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

src/dbSta/src/dbNetwork.cc Show resolved Hide resolved
src/dbSta/src/dbNetwork.cc Outdated Show resolved Hide resolved
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/dbSta/src/dbNetwork.cc Outdated Show resolved Hide resolved
src/dbSta/src/dbNetwork.cc Outdated Show resolved Hide resolved
Signed-off-by: andyfox-rushc <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty merged commit eba58a2 into The-OpenROAD-Project:master Dec 31, 2024
11 checks passed
@zint99
Copy link

zint99 commented Jan 15, 2025

Hi, @andyfox-rushc. Thanks for your contribution to the work on hierarchy support in ODB. It seems like some performance issue with hierarchical ODB when I try before, i.e., very slow on large hierarchical designs. So, I wanna know if there is any more update for ODB hierarchical or if it's already a stable version to use. Very thanks for your reply!

@andyfox-rushc
Copy link
Contributor Author

Hi, Joy, thank you for the interest in the hierarchy project. Yes, you are quite right, it is very much a work in progress. If possible please could you send me ([email protected]) or attach to this thread, a sample large case for me to try and I will endeavour to clean up the performance. I am currently working through cts and then once we have gcd going through the whole flow will iterate to improve. Thanks again, andy.

@andyfox-rushc
Copy link
Contributor Author

andyfox-rushc commented Jan 15, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants