-
Notifications
You must be signed in to change notification settings - Fork 634
rsz: Buffering and sizing improvements #6564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsz: Buffering and sizing improvements #6564
Conversation
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Dashboard link for when this PR is combined with appropriate flow script changes: https://dashboard.precisioninno.com/compare?sourceAType=Commit&sourceBType=Commit&sourceBName=3ac73fd1cbba34b80953390fc9412c84c3921133&sourceBID=16&sourceAName=c6905f5d5dab4c61d923ba4f164eb2335359cba9&sourceAID=5004 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
needs attention |
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Martin Povišer <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
After updates the QoR from this change has degraded: https://dashboard.precisioninno.com/compare?sourceAType=Commit&sourceBType=Commit&sourceBName=3a4a4b5c10a7f036120c4bae4be4e69c1c346062&sourceBID=21&sourceAName=a2e7a0fe4d14cb0382446a3843ee594f696f7de8 I'll need to investigate. |
I've found the cause: |
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Martin Povišer <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
CI green |
Is there an ORFS PR that goes with this or can it be merged as is? |
It requires metric updates, possibly resolving gf12/ariane congestion. I will pick this up in the morning. If you don't mind the transient secure CI failure this can be merged right away. |
this is gpl's fault! |
GPL_KEEP_OVERFLOW=0 works as a workaround to fix ariane in CI |
This PR combines a number of related resizer changes impacting QoR:
repair_design -buffer_gain
)It supersedes #6332