Skip to content

rsz: Buffering and sizing improvements #6564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

openroad-ci
Copy link
Collaborator

This PR combines a number of related resizer changes impacting QoR:

  • Improvements to gain buffering (repair_design -buffer_gain)
  • Pre-selection of buffers used for repair to filter out slow and delay buffers (except for hold repair)
  • Replacing resize to target slew with a fanout-of-4 rule
  • Restructuring of repair_design to do minimal resizing in response to a violation

It supersedes #6332

povik added 14 commits January 21, 2025 17:43
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
@povik
Copy link
Contributor

povik commented Jan 21, 2025

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@maliberty
Copy link
Member

09:38:53  The following tests FAILED:
09:38:53  	366 - gpl.convergence01.tcl (Failed)
09:38:53  	367 - gpl.convergence01.py (Failed)
09:38:53  	389 - gpl.simple01-td.tcl (Failed)
09:38:53  	390 - gpl.simple01-td.py (Failed)
09:38:53  	391 - gpl.simple01-td-tune.tcl (Failed)
09:38:53  	392 - gpl.simple01-td-tune.py (Failed)

needs attention

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Martin Povišer <[email protected]>
@povik
Copy link
Contributor

povik commented Feb 28, 2025

@povik
Copy link
Contributor

povik commented Mar 4, 2025

After updates the QoR from this change has degraded: https://dashboard.precisioninno.com/compare?sourceAType=Commit&sourceBType=Commit&sourceBName=3a4a4b5c10a7f036120c4bae4be4e69c1c346062&sourceBID=21&sourceAName=a2e7a0fe4d14cb0382446a3843ee594f696f7de8

I'll need to investigate.

I've found the cause: getSwappableCells stopped returning the original size. I would've wished this came with more of a warning.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Martin Povišer <[email protected]>
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@povik
Copy link
Contributor

povik commented Mar 18, 2025

CI green

@maliberty
Copy link
Member

Is there an ORFS PR that goes with this or can it be merged as is?

@povik
Copy link
Contributor

povik commented Mar 18, 2025

It requires metric updates, possibly resolving gf12/ariane congestion. I will pick this up in the morning. If you don't mind the transient secure CI failure this can be merged right away.

@povik
Copy link
Contributor

povik commented Mar 19, 2025

The ariane congestion is due to buffer placement into bottom left corner. It doesn't happen on master, I'm investigating.

Screenshot 2025-03-19 at 14 09 49

@gudeh
Copy link
Contributor

gudeh commented Mar 19, 2025

this is gpl's fault!

@povik
Copy link
Contributor

povik commented Mar 19, 2025

GPL_KEEP_OVERFLOW=0 works as a workaround to fix ariane in CI

@maliberty maliberty merged commit d4bb950 into The-OpenROAD-Project:master Mar 19, 2025
11 checks passed
@maliberty maliberty deleted the rsz-gain-buffer-changes branch March 19, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants