update sta submodule #6606
Open
update sta submodule #6606
+52
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
gadfort
reviewed
Jan 28, 2025
src/dbSta/src/dbReadVerilog.cc
Outdated
Comment on lines
140
to
141
| sta::VerilogReader* verilog_reader = new sta::VerilogReader(verilog_network); | ||
| verilog_reader->read(filename); |
There was a problem hiding this comment.
I'm trying to figure this out. If I delete the pointer, a bunch of tests fail with the error [ERROR STA-1398] top is not a verilog module.
There was a problem hiding this comment.
@gadfort my last commit fix the leak by mimic the old behavior. I had to make the verilog reader a class member, in order to avoid creating multiple readers, and I delete it once the link design is complete.
Signed-off-by: Eder Monteiro <[email protected]>
maliberty
reviewed
Jan 28, 2025
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Vitor Bandeira <[email protected]>
Signed-off-by: Vitor Bandeira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure ci started in the branch secure-sta_fix.