Skip to content

Conversation

@LucasYuki
Copy link
Contributor

Issue #8477.

Removes the 10% limit of fillers cells removed during routability.

@LucasYuki LucasYuki requested a review from gudeh September 30, 2025 18:18
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@LucasYuki
Copy link
Contributor Author

LucasYuki commented Sep 30, 2025

Summary of metrics across all design tests.

image

@maliberty
Copy link
Member

I'm confused as the issue says

The current code should limit the maximum number of filler cells removed to 10%, but there is a bug that allows up to 100% of the filler cells to be removed.

but this is Removes the 10% limit of fillers. There is no such limit per the issue.

@gudeh
Copy link
Contributor

gudeh commented Oct 1, 2025

As mentioned on a previous meeting we noticed it could be beneficial to remove the max cap filler removal, and allow for all fillers to be potentially removed.

Initially we wanted to remove at most 10% of the fillers. Although, there was a bug which we were accidentally removing all fillers, but even still this showed as a good outcome on some private designs, since after fixing the bug and removing only 10% of fillers showed congestion problems during GRT on private designs. By removing the max cap we see no divergences during GPL (on contrary to what I observed previously where multiple public designs were diverging consistently).

So we understand it would be better to instead of fixing the cap, just remove it. Since we do not see divergences and private designs benefit from removing the cap.

@maliberty
Copy link
Member

Needs a small metric update
11:59:52 + ./test/regression jpeg_sky130hd
12:21:05 jpeg_sky130hd (tcl) FAIL GRT::ANT::errors 1 > 0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: LucasYuki <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gudeh
Copy link
Contributor

gudeh commented Oct 20, 2025

All green @maliberty

@maliberty maliberty merged commit 4f47673 into The-OpenROAD-Project:master Oct 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants