dbCompare is an implementation artifact of db.h. Make an inc. #8510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20251001-no-cyclic-dep
branch
from
16d3169 to
14d7500
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Oct 1, 2025
|
I like this change. If you merge master it should clear up the CI failures. |
To avoid accidentally creating circular dependencies that confuses tools and users, make it very clear that this is an implementation detail. Signed-off-by: Henner Zeller <[email protected]>
hzeller
force-pushed
the
feature-20251001-no-cyclic-dep
branch
from
14d7500 to
4184075
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid accidentally creating circular dependencies that confuses tools and users, make it very clear that this is an implementation detail.