Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cts: include ADDITIONAL_LIBS in variables to CTS stage #18

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

oharboe
Copy link
Collaborator

@oharboe oharboe commented Mar 22, 2024

Ideally we provide only the variables relevant for a stage to that stage. Is ADDITIONAL_LIBS relevant, other than for make cts_issue?

What about ADDITIONAL_LEFS?

This is not strictly necessary for the execution of this stage, but it is useful, otherwise .lib files for macros are not included in make cts_issue.

@oharboe
Copy link
Collaborator Author

oharboe commented Mar 22, 2024

@lpawelcz We'll need a bazelisk build *_issue target that creates a _make file which includes all variables for all stages. This will be used for make issue use-case.

@oharboe oharboe closed this Mar 22, 2024
@maliberty
Copy link
Member

This is not strictly necessary for the execution of this stage,

If your cts stage matches ORFS then the .lib are necessary for repair_timing.

@oharboe
Copy link
Collaborator Author

oharboe commented Mar 22, 2024

This is not strictly necessary for the execution of this stage,

If your cts stage matches ORFS then the .lib are necessary for repair_timing.

Why dont I get an error without the .lib files in CTS?

@maliberty
Copy link
Member

sta will treat them as black boxes with no timing (as will proprietary tools).

@oharboe
Copy link
Collaborator Author

oharboe commented Mar 22, 2024

sta will treat them as black boxes with no timing (as will proprietary tools).

how can I tell which stages use .lef and .def files?

@oharboe oharboe reopened this Mar 22, 2024
@oharboe
Copy link
Collaborator Author

oharboe commented Mar 22, 2024

Needs more work, but this is the right approach

@maliberty
Copy link
Member

lef/def are needed just at floorplan and gds generation as they are stored in odb. Liberty are not and are needed at any stage that does timing - it is simplest to assume all stages.

@oharboe oharboe force-pushed the cts-include-additional-libs branch from a32d5a1 to 97e6502 Compare March 22, 2024 20:35
@oharboe oharboe removed the request for review from maliberty March 22, 2024 21:41
@oharboe oharboe force-pushed the cts-include-additional-libs branch 2 times, most recently from 2f1c989 to 21f03ef Compare March 22, 2024 21:53
This is not strictly necessary for the execution of this stage,
but it is useful, otherwise .lib files are not included
in make cts_issue

Signed-off-by: Øyvind Harboe <[email protected]>
@oharboe oharboe force-pushed the cts-include-additional-libs branch from 21f03ef to 02c09ae Compare March 23, 2024 08:58
@oharboe
Copy link
Collaborator Author

oharboe commented Mar 23, 2024

lef/def are needed just at floorplan and gds generation as they are stored in odb. Liberty are not and are needed at any stage that does timing - it is simplest to assume all stages.

Fixed.

@oharboe oharboe merged commit dee68e9 into main Mar 23, 2024
10 checks passed
@oharboe oharboe deleted the cts-include-additional-libs branch March 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants