Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from upstream/master and fix PullRequest.get_pr_comments bug #8

Merged
merged 20 commits into from
Mar 12, 2025

Conversation

sombraSoft
Copy link

@sombraSoft sombraSoft commented Mar 12, 2025

Our pipelines that are using this forked action are failing with the following error:

Traceback (most recent call last):
  File "/usr/local/bin/post", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/usr/local/lib/python3.13/site-packages/clang_tidy_review/post.py", line 103, in main
    exit_code = post_review(
        pull_request, review, args.max_comments, lgtm_comment_body, args.dry_run
    )
  File "/usr/local/lib/python3.13/site-packages/clang_tidy_review/__init__.py", line 1347, in post_review
    pull_request.post_lgtm_comment(lgtm_comment_body)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/clang_tidy_review/__init__.py", line 373, in post_lgtm_comment
    for comment in comments:
                   ^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/github/PaginatedList.py", line 84, in __iter__
    newElements = self._grow()
  File "/usr/local/lib/python3.13/site-packages/github/PaginatedList.py", line 95, in _grow
    newElements = self._fetchNextPage()
  File "/usr/local/lib/python3.13/site-packages/github/PaginatedList.py", line 3[24](https://github.com/The-OpenROAD-Project/OpenROAD/actions/runs/13801194073/job/38603792944#step:5:25), in _fetchNextPage
    return self._getPage(data, headers)
           ~~~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/github/PaginatedList.py", line 357, in _getPage
    self.__contentClass(self.__requester, headers, self._transformAttributes(element))  # type: ignore
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: PullRequest.get_pr_comments.<locals>.get_element() missing 1 required positional argument: 'completed'

Example: https://github.com/The-OpenROAD-Project/OpenROAD/actions/runs/13801194073/job/38603792944

Currently there's an issue opened in the original repo and a PR that addresses the issue but has not been merged just yet into the original repo.

This PR syncs with upstream and applies the bugfix from Nerixyz/fix/pr-comments

@sombraSoft sombraSoft changed the title Bugfix Updates from upstream/master and github api error bugfix Mar 12, 2025
@sombraSoft sombraSoft changed the title Updates from upstream/master and github api error bugfix Updates from upstream/master and fix PullRequest.get_pr_comments bug Mar 12, 2025
@sombraSoft sombraSoft marked this pull request as ready for review March 12, 2025 08:18
@vvbandeira vvbandeira merged commit f2f6517 into The-OpenROAD-Project:master Mar 12, 2025
1 check passed
@maliberty
Copy link
Member

Thanks. @gadfort this should fix the CI issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants