resized regfiles to align with synth-based sizes #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ng <[email protected]>
oharboe
requested changes
Oct 30, 2024
| "floorplan": [io_constraint], | ||
| "place": [io_constraint], | ||
| "floorplan": [ram_data["io_constraint"]], | ||
| "place": [ram_data["io_constraint"]], | ||
| }, | ||
| verilog_files = ["mock/" + ram + ".sv"], |
There was a problem hiding this comment.
These are mocked register files, i.e. they do not have all the rows. Use "rtl/" for original RTL.
So this leaves me with a question: what size do the new sizes correspond to? The mock/ or rtl/ version?
|
What is the WNS of here in the comment? The nubmer is close to what I recall from floorplan after retiming, whereas CTS WNS is much worse as we pick up a lot of WNS in placement. There should be a table output when the build completes with the WNS from CTS. |
|
Per meeting discussion, cancel this PR and re-submit new one with existing reg file sizes (400 x 400), but with core area that extends more closely to the die boundary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resized reg files at align with synth-based sizes per email discussion.
WNS: -1862 (vs -1877)
No change to DRCs
GPL run time increase: 2:05 vs 1:42
Image of placement density:
Artifacts should exist (was accurate to yesterday's main, but rebased this morning prior to this PR)