Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove memory leak in sublist_search.cpp #2541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove memory leak in sublist_search.cpp #2541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions search/sublist_search.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,20 @@ Node *makeLinkedList(const std::vector<uint64_t> &data) {
return head;
}

/*
* @brief This function dealocates memory related to the given list
* It recursively deletes all of the nodes of the input list.
* @param room the root/head of the input list
* @warning Plese note that the memory for each node has to be alocated using
* new.
*/
void deleteList(Node *const root) {
if (root != NULL) {
deleteList(root->next);
delete root;
}
}

/**
* @brief Main searching function
* @param sublist A linked list which is supposed to be searched in mainList.
Expand Down Expand Up @@ -217,8 +231,8 @@ class TestCases {
log("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
"~");

delete (sublistLL);
delete (mainlistLL);
deleteList(mainlistLL);
deleteList(sublistLL);
}

/**
Expand Down Expand Up @@ -270,6 +284,9 @@ class TestCases {
log("[PASS] : TEST CASE 2 PASS!");
log("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
"~");

deleteList(mainlistLL);
deleteList(sublistLL);
}

/**
Expand Down Expand Up @@ -318,6 +335,9 @@ class TestCases {
log("[PASS] : TEST CASE 3 PASS!");
log("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
"~");

deleteList(mainlistLL);
deleteList(sublistLL);
}
};

Expand Down Expand Up @@ -366,5 +386,8 @@ int main(int argc, char *argv[]) {
} else {
std::cout << "[FALSE] - sublist NOT found in main list\n";
}

deleteList(mainlistLL);
deleteList(sublistLL);
return 0;
}
Loading