fix: correct position validation and boundary handling in DelByPos #785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Problem
The original DelByPos function had incorrect position validation and boundary checks, causing errors when deleting nodes at valid positions, especially at the start and end of the list.
Specifically, the conditions used
pos-1
inconsistently, leading to off-by-one errors and incorrect calls to deletion methods.Solution
pos
is within[1, ll.length]
.when
pos == ll.length`.Testing
DelByPos()
covering success and failure cases.Checklist
(https://github.com/TheAlgorithms/Go/blob/master/CONTRIBUTING.md#New-File-Name-guidelines)
Notes: