Update Armstrong.java#6130
Closed
Patient-Pace-Coder wants to merge 1 commit intoTheAlgorithms:masterfrom
Closed
Conversation
Optimized Armstrong number check by removing string conversion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6130 +/- ##
============================================
- Coverage 73.77% 73.76% -0.01%
- Complexity 5120 5121 +1
============================================
Files 658 658
Lines 17619 17618 -1
Branches 3391 3391
============================================
- Hits 12998 12996 -2
- Misses 4117 4118 +1
Partials 504 504 ☔ View full report in Codecov by Sentry. |
anandfresh
approved these changes
Feb 4, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution! |
|
Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized Armstrong number check by removing string conversion
This update optimizes the Armstrong number check by eliminating the need for string conversion to calculate the number of digits. Instead, the number of digits is calculated using the Math.log10() function. This change improves both performance and readability, as we now compute the number of digits in a more efficient manner without converting the number to a string.
Changes made:
Removed string conversion (Integer.toString()) for calculating the number of digits.
Replaced it with a mathematical approach using Math.log10(num) + 1 to determine the number of digits in the given number.
The logic remains the same for summing each digit raised to the power of the number of digits.
clang-format -i --style=file path/to/your/file.java