Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: 80% faster Project Euler 145 #10445

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Performance: 80% faster Project Euler 145 #10445

merged 3 commits into from
Oct 14, 2023

Conversation

ManpreetXSingh
Copy link
Contributor

@ManpreetXSingh ManpreetXSingh commented Oct 14, 2023 •
edited
Loading

Describe your change:

#8594

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 14, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 14, 2023
@cclauss cclauss merged commit 1969259 into TheAlgorithms:master Oct 14, 2023
5 checks passed
@ManpreetXSingh
Copy link
Contributor Author

@cclauss Thanks for merging the changes! I'm grateful for your quick review and the merge.

@ManpreetXSingh ManpreetXSingh deleted the performance-euler-145 branch October 14, 2023 17:52
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@ManpreetXSingh @sedatguzelsemme
Performance: 80% faster Project Euler 145 (TheAlgorithms#10445)
3cb1d3e 
* Performance: 80% faster Project Euler145

* Added timeit benchmark

* >>> slow_solution() doctest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManpreetXSingh @cclauss