Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented improved algorithm using Numba for Project Euler Problem 73 #11204

Closed
wants to merge 12 commits into from
Closed

Implemented improved algorithm using Numba for Project Euler Problem 73 #11204

wants to merge 12 commits into from

Conversation

venkat1924
Copy link

Existing file with a Python solution to count fractions between 1/3 and 1/2 for denominators up to 12,000 using nested loops and the math module's gcd function. This approach iterates through all possible fractions and counts those meeting the specified criteria.

Added an improved solution utilizing the Numba library for optimized performance. This implementation uses a Numba-optimized function solution decorated with @njit to compile the code to machine code, significantly improving execution speed. The algorithm employs a different approach to count fractions between 1/3 and 1/2. It utilizes a loop with numerator and denominator ranges to calculate the count, avoiding unnecessary iterations by counting the fractions directly meeting the criteria while leveraging Numba's JIT compilation for efficiency.

Fixes #8594

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

venkat1924 and others added 2 commits December 7, 2023 18:29
Existing file with a Python solution to count fractions between 1/3 and 1/2 for denominators up to 12,000 using nested loops and the math module's gcd function. This approach iterates through all possible fractions and counts those meeting the specified criteria.

Added an improved solution utilizing the Numba library for optimized performance. This implementation uses a Numba-optimized function solution decorated with @njit to compile the code to machine code, significantly improving execution speed. The algorithm employs a different approach to count fractions between 1/3 and 1/2. It utilizes a loop with numerator and denominator ranges to calculate the count, avoiding unnecessary iterations by counting the fractions directly meeting the criteria while leveraging Numba's JIT compilation for efficiency.

Fixes #8594
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Dec 7, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

3
"""
phi = list(range(limit + 1))
count = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred while parsing the file: project_euler/problem_073/sol2.py

Traceback (most recent call last):
  File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
    reports = lint_file(
              ^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 35:5.
parser error: error at 34:4: expected one of (, *, +, -, ..., AWAIT, DEDENT, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~

    count = 0
    ^

@venkat1924 venkat1924 closed this Dec 7, 2023
@venkat1924 venkat1924 deleted the fix-euler-problem-73 branch December 7, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize Project Euler solutions
1 participant