-
-
Notifications
You must be signed in to change notification settings - Fork 45.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated topological_sort.py #11289
Closed
Closed
Updated topological_sort.py #11289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 10 test cases
for more information, see https://pre-commit.ci
changed camel case to snake case for testCases
for more information, see https://pre-commit.ci
fixed camel casing
for more information, see https://pre-commit.ci
"Value of type "Collection[str]" is not indexable" potential error fix
Dict, List, and Any to lowercase
added as keyword for list, any, and dict
deleted line 2 import as they were deprecated
imported any
for more information, see https://pre-commit.ci
added list in place of any
list
renamed topological_sort to topological_sort_util as a helper function to topological_sort
for more information, see https://pre-commit.ci
made line length less than 88 for doctests
algorithms-keeper
bot
added
enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Feb 12, 2024
for more information, see https://pre-commit.ci
added sort: list[str] = [] and did the same for visited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting reviews
This PR is ready to be reviewed
enhancement
This PR modified some existing files
tests are failing
Do not merge until tests pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Contributes to #9943
Checklist: