issue #10837 Move fib_recursive_term() outside of fib_recursive() for proper doctest coverage and improved code organization. #11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cursive() for proper doctest coverage and improved code organization.
for more information, see https://pre-commit.ci
imSanko
suggested changes
May 15, 2024
Comment on lines
+86
to
+101
| def fib_recursive_term(i: int) -> int: | ||
| """ | ||
| Calculates the i-th (0-indexed) Fibonacci number using recursion | ||
| >>> fib_recursive_term(0) | ||
| 0 | ||
| >>> fib_recursive_term(1) | ||
| 1 | ||
| >>> fib_recursive_term(5) | ||
| 5 | ||
| >>> fib_recursive_term(10) | ||
| 55 | ||
| >>> fib_recursive_term(-1) | ||
| Traceback (most recent call last): | ||
| ... | ||
| Exception: n is negative | ||
| """ |
There was a problem hiding this comment.
Can we:
- Removed the large block of empty lines in the middle of the fib_recursive function.
- Ensured the docstring for the fib_recursive function is correctly formatted and includes the expected outputs for the doctests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #10837
Describe your change:
Move fib_recursive_term() outside of fib_recursive() for proper doctest coverage and improved code organization.
Checklist: