-
-
Notifications
You must be signed in to change notification settings - Fork 45.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: 25% faster Project Euler 73 #10503 #11553
Open
RamanaMenda
wants to merge
5
commits into
TheAlgorithms:master
Choose a base branch
from
RamanaMenda:performance-project-euler-73
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Performance: 25% faster Project Euler 73 #10503 #11553
RamanaMenda
wants to merge
5
commits into
TheAlgorithms:master
from
RamanaMenda:performance-project-euler-73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anaMenda/OpenSource-Python into performance-project-euler-73
algorithms-keeper
bot
added
awaiting reviews
This PR is ready to be reviewed
and removed
tests are failing
Do not merge until tests pass
labels
Sep 6, 2024
BALAJI24092001
approved these changes
Sep 23, 2024
imSanko
suggested changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try some more test such as:
import unittest
class TestSolution(unittest.TestCase):
def test_small_max_d(self):
self.assertEqual(solution(4), 0)
self.assertEqual(solution(5), 1)
self.assertEqual(solution(8), 3)
def test_large_max_d(self):
self.assertEqual(solution(12000), 7193) # Expected result
def test_invalid_input(self):
with self.assertRaises(ValueError):
solution(-1)
with self.assertRaises(ValueError):
solution(0)
if __name__ == "__main__":
unittest.main()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
#8594
Checklist: