broadcast addr can be NULL

TheAssemblyArmada · Jun 12, 2024 · 80b577a · 80b577a
1 parent 7e32602
commit 80b577a
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/common/wspudp.cpp b/common/wspudp.cpp
@@ -258,19 +258,20 @@ bool UDPInterfaceClass::Open_Socket(SOCKET)
             struct in_addr* tmp_addr = &((struct sockaddr_in*)ifa->ifa_addr)->sin_addr;
             char buf[INET_ADDRSTRLEN];
             inet_ntop(AF_INET, tmp_addr, buf, INET_ADDRSTRLEN);
-            char temp[128];
-            sprintf(temp, "RA95: Found local address: %s\n", buf);
-            fprintf(stderr, temp);
+            fprintf(stderr, "RA95: Found local address: %s\n", buf);
 
             unsigned char* a = new unsigned char[4];
             *((uint32_t*)a) = tmp_addr->s_addr;
             LocalAddresses.Add(a);
 
-            tmp_addr = &((struct sockaddr_in*)ifa->ifa_broadaddr)->sin_addr;
-            inet_ntop(AF_INET, tmp_addr, buf, INET_ADDRSTRLEN);
-            sprintf(temp, "RA95: Using broadcast address of: %s\n", buf);
-            fprintf(stderr, temp);
-            Set_Broadcast_Address(buf);
+            if ((struct sockaddr_in*)ifa->ifa_broadaddr == 0) {
+                fprintf(stderr, "RA95: No broadcast address\n");
+            } else {
+                tmp_addr = &((struct sockaddr_in*)ifa->ifa_broadaddr)->sin_addr;
+                inet_ntop(AF_INET, tmp_addr, buf, INET_ADDRSTRLEN);
+                fprintf(stderr, "RA95: Using broadcast address of: %s\n", buf);
+                Set_Broadcast_Address(buf);
+            }
         }
     }