Cleanup more use of the "long" data type. #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmniBlade
force-pushed
the
cleanup/morelong
branch
from
85cf624
to
478737f
Compare
giulianobelinassi
requested changes
Jun 23, 2024
|
There are changes which seems to have been done by mistake automatically by your text editor. |
OmniBlade
force-pushed
the
cleanup/morelong
branch
from
478737f
to
0fbf032
Compare
|
Should all be cleaned up now. |
giulianobelinassi
requested changes
Jun 24, 2024
|
Aw man, that stupid utf conversion :D |
OmniBlade
force-pushed
the
cleanup/morelong
branch
2 times, most recently
from
3c91025
to
b477720
Compare
|
Okay, really should be cleaned up this time @giulianobelinassi |
OmniBlade
force-pushed
the
cleanup/morelong
branch
from
b477720
to
dcd7303
Compare
giulianobelinassi
requested changes
Jun 25, 2024
redalert/conquer.cpp
Outdated
| @@ -4257,7 +4257,7 @@ bool Force_CD_Available(int cd) | |||
| #endif | |||
|
|
|||
| #ifdef FRENCH | |||
| sprintf(buffer, "Ins�rez le %s", _cd_name[cd]); | |||
| sprintf(buffer, "Ins�rez le %s", _cd_name[cd]); | |||
There was a problem hiding this comment.
I think these are actually fixing a change that went through incorrectly previously.
redalert/conquer.cpp
Outdated
| @@ -4268,7 +4268,7 @@ bool Force_CD_Available(int cd) | |||
| } else { | |||
| #ifdef DVD | |||
| #ifdef FRENCH | |||
| sprintf(buffer, "Ins�rez le %s", _cd_name[4]); | |||
| sprintf(buffer, "Ins�rez le %s", _cd_name[4]); | |||
This datatype varies in length between platforms so its use is not portable.
OmniBlade
force-pushed
the
cleanup/morelong
branch
from
dcd7303
to
df1760b
Compare
giulianobelinassi
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This datatype varies in length between platforms so its use is not portable.