Cleans up MSVC only warnings pragmas. #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any warnings that need to be disabled at the current warning level are disabled through CMakePresets.json now. Also fixes two warnings seen at current warning level.
giulianobelinassi
approved these changes
Jun 23, 2024
| @@ -196,6 +196,7 @@ unsigned sosCODECDecompressData(_SOS_COMPRESS_INFO* stream, unsigned bytes) | |||
| } | |||
| #endif | |||
| assert(0 && "Unreachable"); | |||
| return 0; | |||
There was a problem hiding this comment.
If this is unreachable then why are you returning 0 here?
There was a problem hiding this comment.
Its in theory reachable while the else branch is ifdef out when compiling with NDEBUG which triggers compiler warnings. Other option is to remove the ifdef and let the else branch ride?
There was a problem hiding this comment.
Well, I would expect the compiler to not complain once assert(0 && string) = assert(0) and hence anything beyond that would fall into dead code.
But perhaps the compiler has bugs...
giulianobelinassi
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any warnings that need to be disabled at the current warning level are disabled through CMakePresets.json now. Also fixes two warnings seen at current warning level.
Obsoletes #981