Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TD] Fix loading of zounds.mix. #1016

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

OmniBlade
Copy link
Contributor

Loading was previously gated behind a check for Special.IsJuvenile which isn't set until later in the init process.

@giulianobelinassi
Copy link
Collaborator

But in this case the Juvenile flag isn't check for loading ZOUNDS.MIX. Is that intended?

@Nyerguds
Copy link

I agree with @giulianobelinassi; the fix should just be to move the load to a point after the conquer.ini settings reading.

@OmniBlade OmniBlade force-pushed the fixes/zounds branch 2 times, most recently from 3ac99e4 to fac8742 Compare June 25, 2024 08:15
@OmniBlade
Copy link
Contributor Author

The files in zounds.mix have a different extension and wouldn't have been used unless IsJuvenile was set, but I've refactored it to check and load after conquer.ini has been loaded so the check is correct now rather than removing it.

Loading was previously gated behind a check for Special.IsJuvenile which isn't set until later in the init process.
@giulianobelinassi giulianobelinassi merged commit d07e8da into TheAssemblyArmada:vanilla Jun 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants