Replace strlen upper bound with checks for '\0' #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmniBlade
approved these changes
Jun 26, 2024
Strings in C are always terminated by the '\0' character. We can explore this to avoid sweeping through the string twice. Constructs like `for (i = 0; i < strlen(str); i++)` are even worse, as it will call strlen **for each character of the string**, which is O(n²) instead of O(n). Replace those cases as well. Signed-off-by: Giuliano Belinassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings in C are always terminated by the '\0' character. We can explore this to avoid sweeping through the string twice.
Constructs like
for (i = 0; i < strlen(str); i++)are even worse than this, as it will call strlen for each character of the string, which is O(n ²) instead of O(n), where n = size of string. Replace those cases as well.