Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SORTDRAW when NETWORKING is disabled. #792

Conversation

giulianobelinassi
Copy link
Collaborator

SORTDRAW is used to synchronize object drawing across machines. Since this
consumes CPU for sorting and memory to keep 4 more pointers in the
CellClass, we can disable this when NETWORKING is disabled to save RAM.

Signed-off-by: Giuliano Belinassi [email protected]

SORTDRAW is used to synchronize object drawing across machines. Since this
consumes CPU for sorting and memory to keep 4 more pointers in the
CellClass, we can disable this when NETWORKING is disabled to save RAM.

Signed-off-by: Giuliano Belinassi <[email protected]>
Copy link
Contributor

@tomsons26 tomsons26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see discord

@OmniBlade
Copy link
Contributor

Just to elaborate on @tomsons26 comment, the discord conversation basically concluded that SORTDRAW is either something that Petroglyph cooked up for the remaster or was undefined in the original game builds because the original code matches the #elif code paths, not the #ifdef SORTDRAW codepaths so it is unlikely to affect network sync (subject to testing).

@OmniBlade
Copy link
Contributor

Merge of #457 makes this redundant.

@OmniBlade OmniBlade closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants