Get DirectDraw backend to work with real hardware #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be actually related to some cards being unable to display the 640x400 mode. In that case we fallback ot a 640x480 resolution. Signed-off-by: Giuliano Belinassi <[email protected]>
Both DirectDraw and DirectSound backends works fine under Win9x. Signed-off-by: Giuliano Belinassi <[email protected]>
ccawley2011
reviewed
Sep 26, 2022
| @@ -46,8 +46,19 @@ else() | |||
| set(OPENAL TRUE) | |||
| endif() | |||
|
|
|||
| if(WIN32 AND WIN9X) | |||
| if(SDL2) | |||
| message("note: Use DSOUND or SDL1 for video support in Windows 9x.") | |||
There was a problem hiding this comment.
Suggested change
| message("note: Use DSOUND or SDL1 for video support in Windows 9x.") | |
| message("note: Use DDRAW or SDL1 for video support in Windows 9x.") |
Comment on lines
+677
to
+679
| /* giulianob: C&C runs by default in 640x400 resolution, which is | ||
| by some videocards even back then. In failure to set the | ||
| resulution, try to fallback into 640x480. */ |
There was a problem hiding this comment.
Suggested change
| /* giulianob: C&C runs by default in 640x400 resolution, which is | |
| by some videocards even back then. In failure to set the | |
| resulution, try to fallback into 640x480. */ | |
| /* giulianob: C&C runs by default in 640x400 resolution, which isn't | |
| supported by some video cards even back then. If it fails to set | |
| the resolution, try to fall back to 640x480. */ |
There was a problem hiding this comment.
the original code for 480 should be restored in InitDDraw, see original source repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the problem of DirectDraw failing to set the video mode because the card rejects 640x400 mode, as did my NVIDIA TNT2.
This also marks both DirectDraw and DirectSound backends as supported, as we now support Windows 9x and they work fine in those systems.